DRYer instantiation of Forms

1
2
3
4
5
6
def form_kwargs(request):
    kwargs = {}
    if request.method == 'POST':
        kwargs['data'] = request.POST
        kwargs['files'] = request.FILES
    return kwargs

More like this

  1. Gzip decorator by SmileyChris 4 years, 9 months ago
  2. newforms field callback helper by SmileyChris 6 years ago
  3. Allow separation of GET and POST implementations by agore 11 months, 1 week ago
  4. Honeypot Field by SmileyChris 6 years, 1 month ago
  5. LoginAsForm - Login as any User without a password by johnboxall 3 years, 11 months ago

Comments

mark0978 (on April 21, 2009):

Maybe its just me, but I don't see how this is "DRY"er. Not even sure what the point of it is.

#

SmileyChris (on May 6, 2009):

Normally, you'd write:

if request.method == 'POST':
    form = MyForm(data=request.POST, files=request.FILES)
    if form.is_valid():
         form.save()
         # Redirect
else:
    form = MyForm()

Now you write:

form = MyForm(**form_kwargs(request))
if form.is_valid():
     form.save()
     # Redirect

#

SmileyChris (on April 25, 2010):

PS: if you'd rather not bother with a helper like this, the method of instanciating a form only once for both cases is still useful.

The most simple case is (where files aren't involved and you always expect at least one thing in your POST):

form = MyForm(data=request.POST or None)
if form.is_valid():
    form.save()
    # Redirect

#

(Forgotten your password?)